search

open-quantum-safe / liboqs

C library for prototyping and experimenting with quantum-resistant cryptography
https://openquantumsafe.org/
Other
1.82k stars 447 forks source link

Use python code in python (CBOM again) #1407

Closed baentsch closed 1 year ago

baentsch commented 1 year ago

@Martyrshot @bhess See this code: https://github.com/open-quantum-safe/liboqs/blob/341cf224270535e1a5769263f2dd2641fcf2c301/scripts/copy_from_upstream/copy_from_upstream.py#L619-L622

It is a) weird (as already stated in your own comment) and b) makes (remote/CI) debugging see e.g. this error log hard.

--> Would you be willing to do a PR to call python code the way it should be called from within python? That way it should be possible to get python stack traces/more easily understand the errors in code called (update_cbom.py in this case)?

@bhess: This is ultimately triggered by #1337 for which I already had to do a workaround to #1406... All this --also due to very long CI run times-- by now cost me 2 hours and I am unwilling to invest more time to debug & work around these issues. Please let me know whether you'd be willing to fix this issue, #1406, and find the CBOM-generation error in #1405, currently visible in the error log.

bhess commented 1 year ago

I'll look into the issue next week.

bhess commented 1 year ago

Fixed by #1412