open-quantum-safe / liboqs

C library for prototyping and experimenting with quantum-resistant cryptography
https://openquantumsafe.org/
Other
1.88k stars 460 forks source link

Should ship a pkg-config file #1434

Closed clausecker closed 1 year ago

clausecker commented 1 year ago

Your Rust bindings currently ship a static copy of liboqs. For shipping Rust binaries based on liboqs with unbundled libraries in package managers, we need the Rust bindings to be able to unbundle liboqs. The maintainers of the Rust bindings told me that this is made difficult as liboqs does not ship a pkg-config file: https://github.com/open-quantum-safe/liboqs-rust/issues/190

Perhaps you could ship such a file?

dstebila commented 1 year ago

I don't think any of us have experience working with pkg-config so we wouldn't know what to create nor how to test it. Are you able to prepare something?

clausecker commented 1 year ago

Unfortunately I don't know cmake well enough to have an immediate answer to your question.

tranzystorekk commented 1 year ago

Just created a draft pkgconfig PR, should provide something to start off with, but I'll gladly accept any feedback as a first-time contributor to this project.