Algorithm selection clarification

open-quantum-safe / liboqs

C library for prototyping and experimenting with quantum-resistant cryptography

https://openquantumsafe.org/

Other

1.68k stars 414 forks source link

Algorithm selection clarification #1784

Closed beldmit closed 1 month ago

beldmit commented 1 month ago

Fixes #1781

[ ] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
[ ] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

beldmit commented 1 month ago

Feel free to adjust my best English :)

baentsch commented 1 month ago

Feel free to adjust my best English :)

Telling this to a Swiss/German sounds futile :-)

Thanks for the doc improvement! In the future, may I (or rather mother Earth) ask to tag documentation-only fixes with "[skip ci]" in the commit message to avoid some servers doing pointless tests?

beldmit commented 1 month ago

@baentsch sure. Probably it's worth adding to the PR checklist? And I also can fail the md syntax (and regularly do)

baentsch commented 1 month ago

can fail the md syntax

Good point. Are you aware of a (CI) tool catching this?

beldmit commented 1 month ago

AFAIK openssl uses some ruby tool for this purpose

beldmit commented 1 month ago

https://github.com/openssl/openssl/blob/master/Configurations/unix-Makefile.tmpl#L1172-L1179