search

open-quantum-safe / liboqs

C library for prototyping and experimenting with quantum-resistant cryptography
https://openquantumsafe.org/
Other
1.68k stars 414 forks source link

CMakeLists: add ppc case to known archs #1816

Open barracuda156 opened 3 weeks ago

barracuda156 commented 3 weeks ago

This is a trivial PR: it simply adds ppc to a list of known archs, retaining a warning re no CI for this platform.

I have confirmed the build on Darwin ppc for liboqs 0.10.1 with no other alterations to the code.

barracuda156 commented 3 weeks ago

@SWilson4 I just thought we may need to verify one thing. What is the value of CMAKE_SYSTEM_PROCESSOR when the build is done on 10.5 for ppc64? If it uses uname -p under the hood, this returns powerpc, but the build arch should be ppc64.

I cannot test that immediately, since I have no build environment on 10.5, but let me check with CMake documentation.

A fallback would be to use CMAKE_OSX_ARCHITECTURES when on Apple, that returns a value matching the arch of the build. (Since gcc does not support fat builds, it will be a single arch always, on PowerPC.)

barracuda156 commented 1 week ago

@SWilson4 @baentsch Sorry for a delay, will finalize this over a coming weekend.

baentsch commented 4 days ago

@SWilson4 @baentsch Sorry for a delay, will finalize this over a coming weekend.

@barracuda156 Please let us know when you're ready. Should this be moved to Draft to avoid an unintended merge?