Add XMSS-SHA256_{10, 16, 20}_192 parameters

open-quantum-safe / liboqs

C library for prototyping and experimenting with quantum-resistant cryptography

https://openquantumsafe.org/

Other

1.68k stars 414 forks source link

Add XMSS-SHA256_{10, 16, 20}_192 parameters #1817

Closed cothan closed 2 weeks ago

cothan commented 3 weeks ago

Signed-off-by: Duc Tri Nguyen dnguye69@gmu.edu

Add additional XMSS parameters to meet NIST SP 800 208.
Add emoji to Table parameters sig_stfl_xmss.h, I hope it's helpful and save developer time.
Add KATs.
Add tests.

[ ] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
[ ] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)

cothan commented 3 weeks ago

So the 1 failed check because it's timeout :((

cothan commented 3 weeks ago

@ashman-p , thank you. I forgot to update the doc. I will make an update soon.

cothan commented 3 weeks ago

Thanks @ashman-p , I've updated README.md, xmss.yml, and xmss.md.

cothan commented 3 weeks ago

@baentsch . I think I miss something, I check the downstream oqs-provider and I don't see XMSS/LMS to be inserted like https://github.com/open-quantum-safe/oqs-provider/pull/413 . This PR add additional parameters to XMSS, so it changes the algorithms list (if we count the parameters in). And it doesn't change APIs. So I think I will remove the 2nd checkbox. What do you think?

ashman-p commented 3 weeks ago

Thanks @ashman-p , I've updated README.md, xmss.yml, and xmss.md.

@cothan Thanks.

SWilson4 commented 3 weeks ago

This looks good to me, but I'll hold off on approving until CI is green. Also, it's probably a good idea to trigger the oqs-provider tests by putting "[trigger downstream]" in a commit message in case of a subtle bug like https://github.com/open-quantum-safe/liboqs/issues/1815.

cothan commented 2 weeks ago

@SWilson4 , Fixed the [trigger downstream] test. All CIs are green. I'll merge when I have your approval.