search

open-quantum-safe / liboqs

C library for prototyping and experimenting with quantum-resistant cryptography
https://openquantumsafe.org/
Other
1.92k stars 466 forks source link

Update OpenSSH downstream branch to OQS-v9 #1898

Closed SWilson4 closed 3 months ago

SWilson4 commented 3 months ago

As per https://github.com/open-quantum-safe/openssh/issues/166.

~ [ ] Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)~ ~ [ ] Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider will also need to be ready for review and merge by the time this is merged.)~

SWilson4 commented 3 months ago

@geedo0 You'll need to set the workflow in OpenSSH to be triggered on workflow_dispatch events.

geedo0 commented 3 months ago

Ack, added the trigger to the PR here.

SWilson4 commented 3 months ago

Apparently the GitHub trigger won't do anything unless the downstream workflow is on the default branch: see https://github.com/open-quantum-safe/openssh/pull/168#issuecomment-2302614810 for discussion.

SWilson4 commented 3 months ago

Trigger tested on commit caea971: see the upstream and and downstream runs. For testing, I disabled the other downstream triggers and set the workflow to be triggered on pushes to this branch; the most recent commit reverts these changes.