open-quantum-safe / liboqs

C library for prototyping and experimenting with quantum-resistant cryptography
https://openquantumsafe.org/
Other
1.92k stars 466 forks source link

Remove hardcoded build patch from test script #1938

Closed iyanmv closed 2 months ago

iyanmv commented 2 months ago

If a user has passed a custom build path to cmake, and then calls for example ninja -C <custom_build_path> run_tests, the script test_acvp_vectors.py fails due to having "build" harcoded in the calls.

Instead, let's use helpers.get_current_build_dir_name() to get the build path and use that instead. This is already done in other scripts (e.g., test_binary.py)

Fixes #1937

dstebila commented 2 months ago

Thanks for the fix!

We're about to make a release of liboqs 0.11.0 from the main branch, so let's hold off on merging this until then.

SWilson4 commented 2 months ago

LGTM as well, but since my approval will enable merge I will hold off on approving until after the release. Thanks very much for the contribution, @iyanmv.