Closed christianpaquin closed 1 year ago
@dstebila, CI says my job is on hold (for the last 19h). Do you know what's going on?
I've clicked approve now, so it's going. Not sure why it wasn't auto-approved for you. If it happens again, just ping me and I'll click approve; will need to investigate more if it keeps happening.
I've clicked approve now, so it's going. Not sure why it wasn't auto-approved for you. If it happens again, just ping me and I'll click approve; will need to investigate more if it keeps happening.
The reason is this approval step: https://github.com/open-quantum-safe/openssl/blob/70d83cacc85b0c45331c16bcb9acf6a233e895e3/.circleci/config.yml#L138-L143
It had been added to eliminate unnecessary CI runs -- and succeeded in doing so in about 40% of cases if I'm looking at the build history. But given that we now hopefully eliminate running this over and over again we could also drop this instruction after having done a final release.
Merged changes from upstream 1.1.1u release.