search

open-quantum-safe / oqs-demos

PARTIALLY SUPPORTED Instructions for enabling the use of quantum-safe cryptography in assorted software using the OQS suite. CONTRIBUTORS WANTED.
https://openquantumsafe.org/
133 stars 74 forks source link

Wireshark Docker Build Fails with WolfSSL Due to Undeclared 'QSC_SIG_CPS' Variable #255

Open shyamarshid opened 10 months ago

shyamarshid commented 10 months ago

Description

Building Wireshark with WolfSSL support using the provided Dockerfile (after adding wolfssl support) fails due to an undeclared variable 'QSC_SIG_CPS' in packet-tls-utils.c.

Error Message

/tmp/wireshark-3.4.9/epan/dissectors/packet-tls-utils.c:1259:1: error: 'QSC_SIG_CPS' undeclared here (not in a function); did you mean 'QSC_SIGS'? 1259 | QSC_SIG_CPS

Temporary Fix

Commenting out the following line in the Dockerfile resolves the build issue: #sed -i "s/ { 0x080b, "rsa_pss_pss_sha512" },/ { 0x080b, "rsa_pss_pss_sha512" },\nQSC_SIG_CPS/g" epan/dissectors/packet-tls-utils.c

This line seems intended to insert QSC-related definitions, but the 'QSC_SIG_CPS' variable is not defined in wolfssl-qsc.h.

Steps to Reproduce

  1. Follow how to enable wolfssl support for this repo mentioned in tutorial : https://www.wolfssl.com/open-quantum-safe-wolfssl-joint-wireshark-integration/
  2. Run docker build -t openquantumsafe/wireshark .
  3. Observe the build error related to 'QSC_SIG_CPS'.
baentsch commented 10 months ago

Thanks for this bug report. Not very likely I'll handle this soon as my focus is on supporting completely free, non-commercial software. Will gladly review & accept a suitable PR of course.

ajbozarth commented 3 weeks ago

298 will be marking wireshark as deprecated, but I believe we should leave this issue open to allow new contributors to potentially "un-deprecate" wireshark and update it to working order