search

open-quantum-safe / oqs-demos

PARTIALLY SUPPORTED Instructions for enabling the use of quantum-safe cryptography in assorted software using the OQS suite. CONTRIBUTORS WANTED.
https://openquantumsafe.org/
132 stars 74 forks source link

Switch off CircleCI #294

Open baentsch opened 2 months ago

baentsch commented 2 months ago

The project already started to move to GH CI. This issue is to suggest completing the move off CCI.

ajbozarth commented 2 weeks ago

As I've mentioned in previous oqs calls, after wrapping up #298 I plan to start work moving the CI to GitHub. This seems to be the primary issue for tracking that work, but #213 and #284 seem to duplicate the general move to GitHub Actions work. In addition #300 #301 and #308 might be straight forward to include spending how the process goes.

In preparation for this work I just wanted to note down the relevant issues for tracking

baentsch commented 2 weeks ago

but https://github.com/open-quantum-safe/oqs-demos/issues/213 and https://github.com/open-quantum-safe/oqs-demos/issues/284 seem to duplicate the general move to GitHub Actions work

Not totally right: #213 calls for creating cross-platform docker images: I did this in #214 only for oqs-provider/ossl3 and just for two platforms as a proof-of-concept that the move to GH and dockerx works. This may be simple to extend to all demos but I wouldn't be surprised if more problems occur than you may feel comfortable doing in one PR. Let's see how it turns out (whether the same adaptations in all images are required). The reference in the first line item indeed predates this issue and also #284 became an issue in its own right instead of staying bundled up as the forth line item. The goal of creating #294 and #284 was to motivate others to contribute smaller, more focused PRs instead of solving everything in one go tackling #213.

ajbozarth commented 2 weeks ago

This may be simple to extend to all demos but I wouldn't be surprised if more problems occur than you may feel comfortable doing in one PR

Given I built and tested all my work in #298 on both macOS and a RHEL VM, I believe this should just be a config, but as you said well see what happened when I get into it

The goal of creating https://github.com/open-quantum-safe/oqs-demos/issues/294 and https://github.com/open-quantum-safe/oqs-demos/issues/284 was to motivate others to contribute smaller, more focused PRs instead of solving everything in one go tackling https://github.com/open-quantum-safe/oqs-demos/issues/213.

That makes sense, once I get into it I'll see how creating the different parts of the CI flow and maybe decide to separate the work as the issues are separated.

The my initial primary goal is to move the automated testing CI off on circleCI and onto GitHub Actions, cross platform support and deployment will either come after or hand-in-hand depending on how it goes (I've never wrote GH Actions from scratch, only edited existing configs, so hopefully I'll be learning new tricks along the way)