search

open-quantum-safe / tsc

OQS Technical Steering Committee resources
https://openquantumsafe.org/
Creative Commons Attribution 4.0 International
3 stars 5 forks source link

Create new private liboqs-cupqc repository #63

Closed praveksharma closed 3 months ago

praveksharma commented 3 months ago

This creates a new private repository to work on integrating NVIDIA's cupqc in liboqs. This work shall remain private temporarily at NVIDIA's request to not expose the API calls against cupqc before it is merged into liboqs main.

Users with write access:

clowarden[bot] commented 3 months ago

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Github

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

clowarden[bot] commented 3 months ago

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Directory

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

ryjones commented 3 months ago

@praveksharma please look at the change I made

praveksharma commented 3 months ago

Thank you @ryjones, this looks good to me!

clowarden[bot] commented 3 months ago

Reconciliation completed

✅ The reconciliation completed successfully and all changes have been applied across the services!

Changes applied

Github

praveksharma commented 2 months ago

You are correctly interpreting the changes made in this PR @baentsch . Thank you for raising your concerns.

While this private repo is made for working on these changes the eventual PR to merge the changes into liboqs would be public. Any sub-optimal choices pointed out by reviewers would then only result in a longer wait till the PR is accepted - the health of liboqs will not be affected.

Although I don't see why more OQS team members should not be involved in this integration should they wish to be. I shall speak with the NVIDIA team this week so we are on the same page about this; assuming this proposal is not faced with objection I shall solicit more participation in the next status call and on the OQS mailing list.

praveksharma commented 2 months ago

@ryjones I've confirmed that the changes made in this PR are accurate however @stevenireeves who is in liboqs-cupqc-maintainers is unable to access the repo (GitHub serves them the “This is not the web page you are looking for.” page).

I'm unable to confirm access rights in repo's settings page; could you please check if stevenireeves has the correct access rights?

stevenireeves commented 2 months ago

@ryjones I've confirmed that the changes made in this PR are accurate however @stevenireeves who is in liboqs-cupqc-maintainers is unable to access the repo (GitHub serves them the “This is not the web page you are looking for.” page).

I'm unable to confirm access rights in repo's settings page; could you please check if stevenireeves has the correct access rights?

Bump

ryjones commented 2 months ago

@stevenireeves you need to accept the pending invite

stevenireeves commented 2 months ago

@stevenireeves you need to accept the pending invite

@ryjones Thanks, for some reason github didn't send me an email to approve the request. I verify that I have access now...