Closed beef-broccoli closed 10 months ago
hmmm, so one of the checks says all reactions have the same ID, which i can verify is true (all of them has the same ID ord-c2e0e8e7b99b4eb8b2894520507ed3a0). Is it something simple that i missed? Does the spreadsheet need an index column?
I believe this should be fixed if you omit the reaction_id
from the Reaction template before the enumeration. This is something that we should have the enumeration script check for in the future, but would you mind redoing the enumeration for this submission?
edit: https://github.com/open-reaction-database/ord-schema/issues/697
Looks like reaction id issue is resolved. Here's a zip folder of everything again, with an updated template.
Also not sure whether the descriptions were included. If you need a name and description: name: Pd-catalyzed C-H arylation of imidazole with aryl bromide description: palladium-catalyzed imidazole C5-H arylation reactivities with 8 aryl bromides and 8 imidazoles are evaluated with 24 monophosphine ligands.
Thanks!
The name and description can be added by inserting two lines at the beginning of the dataset pbtxt, see attached
A few questions to double-check some minor points. I'm looking at Fig 4 of the preprint, so apologies if this is wrong:
details
field of a SMILES or NAME compound identifier isn't totally necessary (currently used for the ligand component) and could be removedNAME
identifiers for compounds that refer to generic classes (e.g., "aryl bromide substrate", "imidazole substrate") rather than the name of the compound itself. It's okay to leave it in though!If you are pressed for time, feel free to simply clarify the KOPiv quantity and I can make the changes to the rest of the template.
Thanks for your feedback!
Somehow the enumeration (or maybe from the template) generated an empty "name" identifier for each reaction that throws an error when checked by submission script. This was fixed.
Sorry to be picky, but I think the name and description got removed from the latest submission!
Sorry! it was my fault. Forgot to add it in.
Dataset of a pd-catalyzed C-H arylation reaction with various aryl bromides, imidazoles and ligands.
Associated with publication, Fig. 4 and related texts in the manuscript. Experimental details can be found in SI Section 9.
Reaction template, result spreadsheet and dataset pbtxt files are also included. submission 08-18-23.zip