open-reaction-database / ord-data

Official data repository for the Open Reaction Database
https://open-reaction-database.org
Creative Commons Attribution Share Alike 4.0 International
210 stars 53 forks source link

C-H arylation dataset submission #174

Closed beef-broccoli closed 10 months ago

beef-broccoli commented 11 months ago

Dataset of a pd-catalyzed C-H arylation reaction with various aryl bromides, imidazoles and ligands.

Associated with publication, Fig. 4 and related texts in the manuscript. Experimental details can be found in SI Section 9.

Reaction template, result spreadsheet and dataset pbtxt files are also included. submission 08-18-23.zip

beef-broccoli commented 11 months ago

hmmm, so one of the checks says all reactions have the same ID, which i can verify is true (all of them has the same ID ord-c2e0e8e7b99b4eb8b2894520507ed3a0). Is it something simple that i missed? Does the spreadsheet need an index column?

connorcoley commented 11 months ago

I believe this should be fixed if you omit the reaction_id from the Reaction template before the enumeration. This is something that we should have the enumeration script check for in the future, but would you mind redoing the enumeration for this submission?

edit: https://github.com/open-reaction-database/ord-schema/issues/697

beef-broccoli commented 11 months ago

Looks like reaction id issue is resolved. Here's a zip folder of everything again, with an updated template.

submission 08-21-23.zip

beef-broccoli commented 11 months ago

Also not sure whether the descriptions were included. If you need a name and description: name: Pd-catalyzed C-H arylation of imidazole with aryl bromide description: palladium-catalyzed imidazole C5-H arylation reactivities with 8 aryl bromides and 8 imidazoles are evaluated with 24 monophosphine ligands.

connorcoley commented 11 months ago

Thanks!

The name and description can be added by inserting two lines at the beginning of the dataset pbtxt, see attached

dataset.pbtxt.zip

A few questions to double-check some minor points. I'm looking at Fig 4 of the preprint, so apologies if this is wrong:

If you are pressed for time, feel free to simply clarify the KOPiv quantity and I can make the changes to the rest of the template.

beef-broccoli commented 10 months ago

Thanks for your feedback!

  1. The discrepancy in reagent amounts are fixed. Base amount was right, so is the equivalents in Fig.4. i forgot that after all the reagents are added, only 150ul out of 200 ul was added to the base plate. A ligand plate was also used so there shouldn't be any solvent or stock solution associated with that, this was also fixed.
  2. Workup changed to addition.
  3. changed to two separate steps: filter and wash
  4. details were removed for ligands
  5. i agree, they are redundant especially since input names are already defined for them
  6. Name and description was also added for the dataset

submission 08-27-23.zip

beef-broccoli commented 10 months ago

Somehow the enumeration (or maybe from the template) generated an empty "name" identifier for each reaction that throws an error when checked by submission script. This was fixed.

submission 08-27-23.zip

connorcoley commented 10 months ago

Sorry to be picky, but I think the name and description got removed from the latest submission!

beef-broccoli commented 10 months ago

Sorry! it was my fault. Forgot to add it in.

submission 08-28-23.zip