search

open-reaction-database / ord-data

Official data repository for the Open Reaction Database
https://open-reaction-database.org
Creative Commons Attribution Share Alike 4.0 International
234 stars 59 forks source link

Skip some checks if there are no *.pb files #30

Closed skearnes closed 4 years ago

skearnes commented 4 years ago

Fixes a failing test on #29

connorcoley commented 4 years ago

If the error is caused not by the absence of the changed_pb_files.txt file, but by the fact that it's empty, I think it would make more sense to modify the process_dataset.py script to handle that case gracefully

skearnes commented 4 years ago

If the error is caused not by the absence of the changed_pb_files.txt file, but by the fact that it's empty, I think it would make more sense to modify the process_dataset.py script to handle that case gracefully

The issue is actually in the for loop; process_datasets is fine but the file has a single character in it that messes up the calls to check_pb.