open-reaction-database / ord-interface

Search/browse interface and APIs for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
20 stars 11 forks source link

View Full Details button not working - unable to open a reaction record #126

Closed bdeadman closed 3 months ago

bdeadman commented 3 months ago

When you have a list of reactions in ORD, you can normally click on "View Full Details" to go to the reaction record. This has recently stopped working.

For example, from the ord_dataset-00005539a1e04c809a9a78647bea649c list and then click on "View Full Details" for the top record it takes me to https://open-reaction-database.org/id/ord-00b95f6f20354bb6923efd18c2b3c116 but it does not load.

bdeadman commented 3 months ago

Tested the above in Chrome, Edge and Firefox.

bdeadman commented 3 months ago

@miori-nd can you have a look at this please? Hopefully it is a simple fix, but I'd like to get it fixed.

miori-nd commented 3 months ago

@miori-nd can you have a look at this please? Hopefully it is a simple fix, but I'd like to get it fixed.

Sure thing

It looks like the Vue frontend is sending a reaction_id to POST https://open-reaction-database.org/api/reactions but it is returning a 422 because it expects a "body" and "reaction_ids". If this recently stopped working, it's probably due to some recent change in the backend API

bdeadman commented 3 months ago

@miori-nd can you have a look at this please? Hopefully it is a simple fix, but I'd like to get it fixed.

Sure thing

It looks like the Vue frontend is sending a reaction_id to POST https://open-reaction-database.org/api/reactions but it is returning a 422 because it expects a "body" and "reaction_ids". If this recently stopped working, it's probably due to some recent change in the backend API

I suspect it only recently stopped working. I can't say I actively tested it recently though.

skearnes commented 3 months ago

I'll take a look today; the API should be expecting reaction_id and not reaction_ids after the move to the new backend.

skearnes commented 3 months ago

Deployed; can you please verify? @i404788

i404788 commented 3 months ago

@skearnes It seems to works now :+1: