Fix reactions parameter name in selected view

open-reaction-database / ord-interface

Search/browse interface and APIs for the Open Reaction Database

https://open-reaction-database.org

Apache License 2.0

20 stars 11 forks source link

Fix reactions parameter name in selected view #147

Closed oshnix closed 3 weeks ago

oshnix commented 3 weeks ago

Followup for the #126 Original fix did not include another place in the application where the same api call was used.

STR:

Open the app.
Open any dataset and select reaction via "Select reaction checkbox"
Click "View 1 selected reactions" button at the bottom right of the screen
"Reaction Set" page will be infinitely loading instead of displaying information about selected reaction

Before Screenshot 2024-11-05 163818

After Screenshot 2024-11-05 163710

Fix is similar to the one in #132

bdeadman commented 3 weeks ago

Hi @oshnix thanks for the fix! I've asked @skearnes or @miori-nd to review the code since they are most familiar with the interface.

For my part, I can verify that bug you found is there on the public interface, and also our staging area. I've not tried that selection function before so it may be an old bug, or it could be due to the recent developments.

miori-nd commented 3 weeks ago

@oshnix Thanks for the bug fix! Approved :)

miori-nd commented 3 weeks ago

@bdeadman I've merged this fix presently @skearnes Please deploy anytime

skearnes commented 3 weeks ago

@miori-nd I've deployed to staging, can you please verify?

miori-nd commented 3 weeks ago

@skearnes Thank you. The original issue has been fixed, so this is good to go to prod. While testing, I found that the Shareable Link for selected sets still has an issue, but it's trivial so I'll just push a fix presently.