search

open-reaction-database / ord-interface

Search/browse interface and APIs for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
20 stars 11 forks source link

Convert reactionIds to a list from a string as expected by API #148

Closed miori-nd closed 3 weeks ago

miori-nd commented 3 weeks ago

While testing https://github.com/open-reaction-database/ord-interface/pull/147 I found that the Shareable Link for any selected set does not load. The fix is to set the computed reactionIds property to a list of reactionIds as expected by the API, not a string

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@645ed41). Learn more about missing BASE report.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #148 +/- ## ======================================= Coverage ? 81.85% ======================================= Files ? 16 Lines ? 1003 Branches ? 0 ======================================= Hits ? 821 Misses ? 182 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

skearnes commented 3 weeks ago

Thanks @miori-nd! Deployed to prod.