search

open-reaction-database / ord-interface

Search/browse interface and APIs for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
18 stars 9 forks source link

Missing `add_rdkit` in database.py in `ord_schema` #74

Closed FanwangM closed 9 months ago

FanwangM commented 9 months ago

The add_rdkit function is used in https://github.com/open-reaction-database/ord-interface/blob/22d298148154995e3865cebaa4cda09168de18f0/ord_interface/client/build_database.py#L66.

But it was not found in https://github.com/open-reaction-database/ord-schema/blob/main/ord_schema/orm/database.py, but only avaliable in https://github.com/open-reaction-database/ord-schema/blob/fe42703ab0ef4fe83a4ae1fb13ecf132971e708f/ord_schema/orm/database.py#L87. Does this affect thie deployment of the database? @skearnes

skearnes commented 9 months ago

This will break if/when we upgrade ord-schema; it's currently pinned to an older version: https://github.com/open-reaction-database/ord-interface/blob/main/setup.py#L47

I'll be working on deploying the new UI soon and will update this as part of that change.

skearnes commented 9 months ago

See also https://github.com/open-reaction-database/ord-interface/pull/73