search

open-reaction-database / ord-interface

Search/browse interface and APIs for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
18 stars 9 forks source link

Sign in with GitHub button redirecting to inactive web editor link #87

Closed bdeadman closed 8 months ago

bdeadman commented 8 months ago

When using the sign in with Git Hub button on the web editor page it goes through to GitHub to authorise the OAuth App to access GitHub account. After approving the access, it then redirects to https://client.open-reaction-database.org/github-callback?code=...... to cause a DNS_PROBE_FINISHED_NXDOMAIN error. I think this should be redirecting to https://open-reaction-database.org/editor/github-callback?......

I can confirm that deleting "client." from the address does take me through to the web editor with my GitHub account signed in.

skearnes commented 8 months ago

Thanks; will fix!

skearnes commented 8 months ago

@bdeadman please try again; I updated the OAuth config on the GitHub side.

bdeadman commented 8 months ago

@skearnes I can confirm that it is directing through to the editor as expected now.