open-reaction-database / ord-interface

Search/browse interface and APIs for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
19 stars 10 forks source link

fix: 90 - Prevent null data from causing an error by patching null data to string #96

Closed miori-nd closed 4 months ago

miori-nd commented 8 months ago

Closes #90 The issue here was the existence of null values in some of the Entities. This caused a crash when attempting to run entity[key].toString(), as one can't run the method on null values. My fix was to patch the null values to strings.

skearnes commented 8 months ago

FYI @miori-nd you can have this auto-close the issue if you set the keywords in the description: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

miori-nd commented 8 months ago

FYI @miori-nd you can have this auto-close the issue if you set the keywords in the description: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

Cool, thanks for the tip :)