reaction card URLs - Githubissues

open-reaction-database / ord-interface

Search/browse interface and APIs for the Open Reaction Database

https://open-reaction-database.org

Apache License 2.0

18 stars 9 forks source link

reaction card URLs #97

Open skearnes opened 5 months ago

skearnes commented 5 months ago

[ ] The publication URL link doesn't seem to point to the publication URL?
[x] The dataset ID should be a link to a query for that dataset.

miori-nd commented 5 months ago

I'd like to work on these

bdeadman commented 5 months ago

@miori-nd I've found another dataset url issue which is potentially related, or maybe something to push to a separate issue.

Links to ORD datasets have been published in articles about ORD but these links are now broken after changes to the ord-interface. We have several example datasets linked in the JACS paper.

The old link is going to: https://client.open-reaction-database.org/id/ord-00b28c352e6a453398fad16ac35a55c6

but it should point to: https://open-reaction-database.org/id/ord-00b28c352e6a453398fad16ac35a55c6

How feasible is it to include a redirect in the ord-interface so if someone accesses an old dataset link it pushes through to the correct location?

miori-nd commented 5 months ago

@bdeadman Thank you for reporting that, we should be able to provide a redirect since both of the links are going to the same domain (open-reaction-database.org) just a different subdomain (the subdomain is the "client." part). I will make a separate issue for that and link it here for tracking purposes.

miori-nd commented 5 months ago

@skearnes Could you provide an example of a broken publication link on production? It seems to me that that might be a data quality issue on specific publication links that happen to be broken. The ones in the test database seem to be working fine in the interface (I am working out of the vue branch though so maybe that's out of sync with what's on production)

skearnes commented 4 months ago

@skearnes Could you provide an example of a broken publication link on production? It seems to me that that might be a data quality issue on specific publication links that happen to be broken. The ones in the test database seem to be working fine in the interface (I am working out of the vue branch though so maybe that's out of sync with what's on production)

https://open-reaction-database.org/search?dataset_ids=ord_dataset-4e9c2fa02a7544fd839206719263345f&limit=100 the publication URL just links back to the search page

bdeadman commented 2 months ago

The client.open-reaction-database redirect works.

Still to do:

DOI to be turned into the publication URL link.