search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

save action on invalid reaction fails silently #346

Closed antonkast-google closed 4 years ago

antonkast-google commented 4 years ago

Open the "full.pbtxt" test case in the reaction editor. Hit "save". Observe that "saving" remains visible indefinitely and the JS console shows an uncaught exception.

If saving an invalid reaction is illegal, the user should see an error message. I would prefer though that save always work.

connorcoley commented 4 years ago

This seems to work fine for the main branch and the editor site for me; was this on a local deployment or on the public editor?

skearnes commented 4 years ago

(Note that using the Dockerfile is the best way to make sure you have a clean build.)

antonkast-google commented 4 years ago

Sorry! My mistake. This does not reproduce when I run from the Docker environment.

I am addicted to running without Docker because I can iterate without "docker build", which takes me half a minute. Also I am observing intermittent long page loading latencies under Docker on my MacBook, seemingly about 30 seconds for the initial response on every other request.

I'd love any advice on good workflow.