search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

Draw compounds only after fully loaded #366

Closed n8kim1 closed 4 years ago

n8kim1 commented 4 years ago

Seems to fix #344; would like testing! This fixes by creating the image node entirely after the compound itself is loaded and we get the data of the image's png.

If this seems good, I'll clean it up.

Having an empty src in the nodes was problematic -- I think that sometimes, we would set src midway during the image loading. It wouldn't load with the new src, nor would it refresh.

codecov[bot] commented 4 years ago

Codecov Report

Merging #366 into main will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   78.60%   78.60%           
=======================================
  Files          21       21           
  Lines        2229     2229           
  Branches      467      467           
=======================================
  Hits         1752     1752           
  Misses        340      340           
  Partials      137      137
skearnes commented 4 years ago

Note that #364 gets rid of the empty src.

n8kim1 commented 4 years ago

Neat -- does that fix the issue too?

I'll keep this PR open for now, if that's ok? Can take another look once #364 is done.

skearnes commented 4 years ago

Neat -- does that fix the issue too?

I'll keep this PR open for now, if that's ok? Can take another look once #364 is done.

Sounds good; #364 is in so you're good to go...

n8kim1 commented 4 years ago

Closed by #344 being closed; switching to SVG's also incorporated these changes.