open-reaction-database / ord-schema

Schema for the Open Reaction Database

https://open-reaction-database.org

Apache License 2.0

95 stars 27 forks source link

Allow whitespace at beginning/end of numeric fields #380

Closed connorcoley closed 4 years ago

connorcoley commented 4 years ago

Might help address #377 - achieving consistent behavior with numeric checks.

codecov[bot] commented 4 years ago

Codecov Report

Merging #380 into main will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #380   +/-   ##
=======================================
  Coverage   77.96%   77.96%           
=======================================
  Files          21       21           
  Lines        2242     2242           
  Branches      468      468           
=======================================
  Hits         1748     1748           
  Misses        358      358           
  Partials      136      136

skearnes commented 4 years ago

If we move to <input type="number" these problems should go away...but I don't feel strongly about starting with this more localized solution.