search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

Catch ValueErrors raised when trying to render molecules #400

Closed connorcoley closed 4 years ago

connorcoley commented 4 years ago

Fixes #383

Bonus typo in the script version due to renamed argument

Let me know if you have strong feelings about a placeholder other than "[Component]"

codecov[bot] commented 4 years ago

Codecov Report

Merging #400 into main will decrease coverage by 0.16%. The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #400      +/-   ##
==========================================
- Coverage   77.69%   77.53%   -0.17%     
==========================================
  Files          21       21              
  Lines        2251     2257       +6     
  Branches      470      470              
==========================================
+ Hits         1749     1750       +1     
- Misses        366      371       +5     
  Partials      136      136
Impacted Files Coverage Δ
ord_schema/scripts/generate_text.py 80.00% <0.00%> (ø)
ord_schema/visualization/filters.py 60.20% <21.42%> (-1.38%) :arrow_down: