search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

Updates for latest closure linter warnings #451

Closed skearnes closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@84ba398). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #451   +/-   ##
=======================================
  Coverage        ?   76.11%           
=======================================
  Files           ?       21           
  Lines           ?     2324           
  Branches        ?      483           
=======================================
  Hits            ?     1769           
  Misses          ?      412           
  Partials        ?      143
antonkast-google commented 4 years ago

Have you looked into the IE compatibility? Since we're not transpiling, my understanding is this will not work on IE 10 or earlier. I don't think that matters.

skearnes commented 4 years ago

Have you looked into the IE compatibility? Since we're not transpiling, my understanding is this will not work on IE 10 or earlier. I don't think that matters.

Agreed; I don't think we need to worry about this right now.