Closed skearnes closed 4 years ago
Merging #452 into main will not change coverage. The diff coverage is
83.33%
.
@@ Coverage Diff @@
## main #452 +/- ##
=======================================
Coverage 76.11% 76.11%
=======================================
Files 21 21
Lines 2324 2324
Branches 483 483
=======================================
Hits 1769 1769
Misses 412 412
Partials 143 143
Impacted Files | Coverage Δ | |
---|---|---|
editor/py/serve.py | 79.72% <83.33%> (ø) |
Note that docker-compose will not be used for deployment on GCP. Instead, we will have a separate VM hosting the database that the frontend VM(s) can connect to. So this PR is really for unblocking local development.
Running
docker-compose up
starts two images: one containing a postgres database and the other containing the ORD web editor. The postgres database is exposed to the editor and can be accessed by connecting toORD_EDITOR_DB
withORD_EDITOR_POSTGRES_PASSWORD
. The postgres container writes to a mounted volume; this ensures that the database persists when restarting the image. On GCP, the mounted volume should be a persistent disk.Also changes the current
ORD_EDITOR_DB
variable, which refers to the location of the local or mounted filesystem, toORD_EDITOR_LOCAL
.