open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

Write binary Datasets when updating submissions #459

Closed skearnes closed 4 years ago

skearnes commented 4 years ago

Related to #457; this enables much faster reading of submitted Datasets.

This adds a --write_binary flag (defaults to True) to process_datasets.py that writes a combined binary Dataset alongside the pbtxt version.

codecov[bot] commented 4 years ago

Codecov Report

Merging #459 into main will increase coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
+ Coverage   76.62%   76.71%   +0.08%     
==========================================
  Files          22       22              
  Lines        2340     2349       +9     
  Branches      484      485       +1     
==========================================
+ Hits         1793     1802       +9     
  Misses        402      402              
  Partials      145      145              
Impacted Files Coverage Δ
ord_schema/process_dataset.py 82.92% <100.00%> (+0.99%) :arrow_up: