search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

Add additional vessel attachments? #465

Closed skearnes closed 4 years ago

skearnes commented 4 years ago

From https://github.com/Open-Reaction-Database/ord-data/pull/14:

  • Under vessel, would it make sense to specify the vessel attachments? We do not have types that are suited to well-plates, which might be an oversight. It seems like we could specify two or three attachments: "perfluoroalkoxy alkane (PFA) mat (Analytical Sales, Cat. No. 96981)", "silicon rubber mat (Analytical Sales, Cat. No. 96982)", and "clamp (Arctic White, Cat. No. AWSC-051001)". I see this is included under the pressure conditions, which is much better than excluding this information. But should we add MAT and CLAMP as vessel attachment types?

Added as CUSTOM attachments (how similar are MAT and CAP?). If these are common attachments we could certainly add them to the enum.