Closed michaelmaser closed 4 years ago
Merging #477 into main will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #477 +/- ##
=======================================
Coverage 76.64% 76.64%
=======================================
Files 23 23
Lines 2077 2077
Branches 463 463
=======================================
Hits 1592 1592
Misses 344 344
Partials 141 141
Also, I think we should leave examples/1_Santanilla_Nanomole_HTE/Santanilla_experiment2_dataset.pbtxt out of this PR and use it to create a PR on ord-data.
@connorcoley do you agree?
Yes, I think it isn't necessary to include the dataset output here. Making it an official submission to ord-data would be terrific.
It looks like your
git add
picked up some unrelated files:
- examples/.DS_Store
- examples/10_Perera_Science_Suzuki/.DS_Store
- examples/2_Nielsen_Deoxyfluorination_Screen/example_nielsen.ipynb
Could you please remove these? And you may want to add
.DS_Store
to the .gitignore.Update: Also examples/1_Santanilla_Nanomole_HTE/.DS_Store
Done.
Also, I think we should leave examples/1_Santanilla_Nanomole_HTE/Santanilla_experiment2_dataset.pbtxt out of this PR and use it to create a PR on ord-data.
@connorcoley do you agree?
Done. Saved for ord-data PR.
Oops, I think you deleted example_nielsen.ipynb entirely instead of reverting your commit. I'd suggest copying it from HEAD and recommitting as-is.
Fixed!
Thanks for the review, @skearnes!
Fully worked example for Santanilla experiment 2 submission. Adds dative SMILES to metal complexes, removes yields and reports only peak areas, adds aliquot step to workup, addresses changes to ord-schema