open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

Add Santanilla example #477

Closed michaelmaser closed 4 years ago

michaelmaser commented 4 years ago

Fully worked example for Santanilla experiment 2 submission. Adds dative SMILES to metal complexes, removes yields and reports only peak areas, adds aliquot step to workup, addresses changes to ord-schema

codecov[bot] commented 4 years ago

Codecov Report

Merging #477 into main will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   76.64%   76.64%           
=======================================
  Files          23       23           
  Lines        2077     2077           
  Branches      463      463           
=======================================
  Hits         1592     1592           
  Misses        344      344           
  Partials      141      141           
connorcoley commented 4 years ago

Also, I think we should leave examples/1_Santanilla_Nanomole_HTE/Santanilla_experiment2_dataset.pbtxt out of this PR and use it to create a PR on ord-data.

@connorcoley do you agree?

Yes, I think it isn't necessary to include the dataset output here. Making it an official submission to ord-data would be terrific.

michaelmaser commented 4 years ago

It looks like your git add picked up some unrelated files:

  • examples/.DS_Store
  • examples/10_Perera_Science_Suzuki/.DS_Store
  • examples/2_Nielsen_Deoxyfluorination_Screen/example_nielsen.ipynb

Could you please remove these? And you may want to add .DS_Store to the .gitignore.

Update: Also examples/1_Santanilla_Nanomole_HTE/.DS_Store

Done.

Also, I think we should leave examples/1_Santanilla_Nanomole_HTE/Santanilla_experiment2_dataset.pbtxt out of this PR and use it to create a PR on ord-data.

@connorcoley do you agree?

Done. Saved for ord-data PR.

Oops, I think you deleted example_nielsen.ipynb entirely instead of reverting your commit. I'd suggest copying it from HEAD and recommitting as-is.

Fixed!

michaelmaser commented 4 years ago

Thanks for the review, @skearnes!