search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

Fixing bug in #479 made in haste #485

Closed connorcoley closed 4 years ago

connorcoley commented 4 years ago

In updating some message helpers to avoid redundant code, I hastily left in the wrong identifier. This patches a new bug from PR #479

codecov[bot] commented 4 years ago

Codecov Report

Merging #485 into main will increase coverage by 0.14%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   76.20%   76.35%   +0.14%     
==========================================
  Files          22       22              
  Lines        2047     2047              
  Branches      459      459              
==========================================
+ Hits         1560     1563       +3     
+ Misses        346      343       -3     
  Partials      141      141
Impacted Files Coverage Δ
ord_schema/message_helpers.py 85.29% <100.00%> (+1.10%) :arrow_up:
skearnes commented 4 years ago

You might consider adding the test that would have caught this :)