search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

is_limiting only applies to REACTANT components #515

Closed skearnes closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #515 (f418c1e) into main (959ab06) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #515   +/-   ##
=======================================
  Coverage   75.80%   75.80%           
=======================================
  Files          25       25           
  Lines        2207     2207           
  Branches      498      498           
=======================================
  Hits         1673     1673           
  Misses        382      382           
  Partials      152      152
skearnes commented 3 years ago

Should this be added to validations.py? If a compound has a non-REACTANT role and is_limiting is defined, raise an error?

I don't think this is necessarily error-worthy if is_limiting = False. Was your intention mostly to clean up the example?

Yes, this is mostly to clean up the example since the editor only outputs is_limiting for REACTANTs and the round-trip tests were failing.