search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

Create a template/checklist for reviewers #528

Open skearnes opened 3 years ago

skearnes commented 3 years ago

Should cover the relevant things such that a second reviewer could quickly grasp what the first reviewer has already verified or looked for...

FanwangM commented 1 year ago

This is not exactly what @skearnes means above, but we can have a checking action run automatically every time there is a data pull request for reaction submission. If not all the list points are checked, the GitHub Action will raise an error, which can be done with https://github.com/marketplace/actions/task-completed-checker. Something like,

image

The [task-completed-checker-action](https://github.com/kentaro-m/task-completed-checker-action) configurations should sit in https://github.com/open-reaction-database/ord-data, not here.

What do you think of this? @connorcoley @skearnes

bdeadman commented 8 months ago

Created a complementary issue ticket in ord-data to handle the dataset review procedure https://github.com/open-reaction-database/ord-data/issues/180#issue-2130618670.

Leaving this issue open as I will be documenting the process for modifying ord-schema when I make changes for #708 .