search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

Add support for reading/writing gzipped messages #551

Closed skearnes closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #551 (c5244f8) into main (a670651) will increase coverage by 0.11%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   75.93%   76.04%   +0.11%     
==========================================
  Files          19       19              
  Lines        1853     1862       +9     
  Branches      452      454       +2     
==========================================
+ Hits         1407     1416       +9     
  Misses        305      305              
  Partials      141      141
Impacted Files Coverage Δ
ord_schema/message_helpers.py 84.18% <100.00%> (+0.39%) :arrow_up:
skearnes commented 3 years ago

Re comment on #552, I thought we decided not to gzip for simplicity? Did I misinterpret? I suppose supporting doesn't hurt either way.

Yes, that's what we decided before I started looking at the Git LFS bandwidth requirements---we get "charged" for every download/clone of the repo, so reducing the size on Git LFS is actually pretty important. Hope that's ok to change?

michaelmaser commented 3 years ago

Gotcha, SGTM