search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
93 stars 26 forks source link

Refactor message subfields to remove nesting #557

Closed michaelmaser closed 3 years ago

michaelmaser commented 3 years ago

Resolves #556. Creating as a draft until we figure out all the fields to rework and their final form.

michaelmaser commented 3 years ago

Meeting notes:

  1. Revert temperature and pressure nesting
  2. Check electrochemistry
skearnes commented 3 years ago

PS https://github.com/open-reaction-database/ord-schema/commit/ee423ca2528ad7b83bbadfe2f902e84eba570ee9 has an example of an earlier migration script.

codecov[bot] commented 3 years ago

Codecov Report

Merging #557 (a49ff79) into main (94e107f) will increase coverage by 0.13%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
+ Coverage   75.85%   75.99%   +0.13%     
==========================================
  Files          18       18              
  Lines        1872     1862      -10     
  Branches      463      463              
==========================================
- Hits         1420     1415       -5     
+ Misses        305      300       -5     
  Partials      147      147
Impacted Files Coverage Δ
ord_schema/__init__.py 100.00% <ø> (ø)
ord_schema/validations.py 69.26% <ø> (+0.36%) :arrow_up:
ord_schema/visualization/filters.py 59.55% <0.00%> (ø)