search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

Only check type and details for non-empty messages #572

Closed skearnes closed 3 years ago

skearnes commented 3 years ago

The editor is currently flagging e.g. IlluminationConditions for new reactions since it has a default UNSPECIFIED type. We only want these messages to be validated if they are non-empty.

Alternatively, we could change things on the editor side so only non-empty messages are sent for validation for these message types.

codecov[bot] commented 3 years ago

Codecov Report

Merging #572 (3907ad0) into main (5093cd1) will decrease coverage by 0.04%. The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
- Coverage   76.14%   76.10%   -0.05%     
==========================================
  Files          18       18              
  Lines        1874     1879       +5     
  Branches      466      467       +1     
==========================================
+ Hits         1427     1430       +3     
- Misses        300      301       +1     
- Partials      147      148       +1
Impacted Files Coverage Δ
ord_schema/validations.py 69.17% <60.00%> (-0.09%) :arrow_down: