open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
93 stars 26 forks source link

Add install_requires to setup.py #601

Closed marcosfelt closed 2 years ago

marcosfelt commented 3 years ago

This fixes #600 by making sure dependencies are installed when the package is installed from pypi or source via pip. This avoids having to clone the whole repository in order to get the package installed.

marcosfelt commented 3 years ago

Any updates on this @skearnes

skearnes commented 2 years ago

Thanks @marcosfelt; sorry for the delay!

skearnes commented 2 years ago

@marcosfelt I think you need to run the format.sh script before this can be merged, so the check_python test will pass.

codecov[bot] commented 2 years ago

Codecov Report

Merging #601 (a5227d6) into main (c736318) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   76.23%   76.23%           
=======================================
  Files          19       19           
  Lines        1990     1990           
  Branches      497      497           
=======================================
  Hits         1517     1517           
  Misses        329      329           
  Partials      144      144           
dcambie commented 2 years ago

@marcosfelt I think you need to run the format.sh script before this can be merged, so the check_python test will pass.

In this case this should be enough ;)

pip install yapf
yapf -i .\setup.py