open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
93 stars 26 forks source link

Add unmeasured amounts to proto #610

Closed connorcoley closed 3 years ago

connorcoley commented 3 years ago

Fixes #605

I think these are all of the changes necessary, but please let me know if I'm forgetting something @skearnes

codecov[bot] commented 3 years ago

Codecov Report

Merging #610 (bf806e0) into main (e228d70) will increase coverage by 0.24%. The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
+ Coverage   76.19%   76.44%   +0.24%     
==========================================
  Files          18       18              
  Lines        1941     1953      +12     
  Branches      480      485       +5     
==========================================
+ Hits         1479     1493      +14     
+ Misses        314      313       -1     
+ Partials      148      147       -1     
Impacted Files Coverage Δ
ord_schema/message_helpers.py 84.25% <81.81%> (+0.07%) :arrow_up:
ord_schema/validations.py 70.39% <100.00%> (+0.34%) :arrow_up:
ord_schema/visualization/filters.py 61.23% <100.00%> (+1.30%) :arrow_up: