search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
93 stars 26 forks source link

Problem with `mybinder` link #622

Closed FanwangM closed 2 years ago

FanwangM commented 2 years ago

Thanks for the impressive work!

I was trying to understand more about ord-schema, but it seems that the binder link is broken. The error occurs when the package tries to check protoc in setup.py. My guess is that the checking happen before the dependencies were installed, which resulted to an error. I am wondering if we can remove the dependency checking in setup.py?

blob:https://mybinder.org/b687a518-c1c6-46ca-87f4-0133f0e2d45c

Additional information to reproduce the errors

I have tried with Google Chrome Version 99.0.4844.82 (Official Build) (64-bit) in Fedora 35 and Window 10. Firefox has been also tried.

Thanks for helping!

skearnes commented 2 years ago

Thanks! I'll take a look; hopefully this is just a quick fix.

FanwangM commented 2 years ago

Thanks a lot!

skearnes commented 2 years ago

The problem seems to be that environment.yml is misconfigured; the first pip listing shows up as requiring no packages.

skearnes commented 2 years ago

Update: that's not it.

Warning: you have pip-installed dependencies in your environment file, but you do not list pip itself as one of your conda dependencies. Conda may not use the correct pip to install your packages, and they may end up in the wrong place. Please add an explicit pip dependency. I'm adding one for you, but still nagging you.

skearnes commented 2 years ago

@fwmeng88 please try https://mybinder.org/v2/gh/skearnes/ord-schema/binder --- will be merged soon!

FanwangM commented 1 year ago

I can host the interface locally now. Thanks for helping! @skearnes