Closed skearnes closed 1 year ago
Merging #666 (5f75842) into main (d12998c) will decrease coverage by
0.05%
. The diff coverage is33.33%
.
@@ Coverage Diff @@
## main #666 +/- ##
==========================================
- Coverage 69.64% 69.59% -0.05%
==========================================
Files 23 23
Lines 2273 2276 +3
Branches 566 567 +1
==========================================
+ Hits 1583 1584 +1
- Misses 585 586 +1
- Partials 105 106 +1
Impacted Files | Coverage Δ | |
---|---|---|
ord_schema/orm/mappers.py | 95.62% <33.33%> (-1.20%) |
:arrow_down: |
re: https://github.com/open-reaction-database/ord-schema/pull/669#issuecomment-1501195186 (@ipendlet)
This is one of the reasons we use binary encodings for the source of truth; as long as we don't change the tag numbers we can rename fields without breaking the encoding.
re: #669 (comment) (@ipendlet)
This is one of the reasons we use binary encodings for the source of truth; as long as we don't change the tag numbers we can rename fields without breaking the encoding.
I've also verified by running ord_schema/scripts/validate_dataset.py
on several datasets in ord-data.
Updates to reaction.proto:
ReactionIdentifier.NAME
has been renamed toREACTION_TYPE
Vessel.plate_id
has been renamed tovessel_id
Vessel.plate_position
has been renamed toposition
Vessel.row
andVessel.column
string fieldsReactionProvenance.reaction_metadata
map from strings toData
messages