Closed skearnes closed 1 year ago
Merging #669 (7f908e2) into main (09c82cb) will increase coverage by
0.04%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #669 +/- ##
==========================================
+ Coverage 69.59% 69.64% +0.04%
==========================================
Files 23 23
Lines 2276 2273 -3
Branches 567 566 -1
==========================================
- Hits 1584 1583 -1
+ Misses 586 585 -1
+ Partials 106 105 -1
Impacted Files | Coverage Δ | |
---|---|---|
ord_schema/orm/mappers.py | 96.81% <ø> (+1.19%) |
:arrow_up: |
ord_schema/orm/rdkit_mappers.py | 92.07% <100.00%> (ø) |
Tests validated and I was able to follow the changes. I am not sure how these might effect the existing files though. Is there a way to make sure that the modifications to the schema don't break passed versions of the protobuff? Or is this something that protobuff handles naturally?
Tests validated and I was able to follow the changes. I am not sure how these might effect the existing files though. Is there a way to make sure that the modifications to the schema don't break passed versions of the protobuff? Or is this something that protobuff handles naturally?
I think you are referring to the changes in #666?
_polymorphic_type
is noword_schema_context
and the values are more readable to match the ORD schema definitions.