reaction role

[qai222]

• Extended ReactionRoleType, added validation functions. Related issue: #682
• Comments about stoichiometry convention. Related issue: #683

[codecov[bot]]

Codecov Report

Merging #684 (e53efbd) into main (aaaed3f) will decrease coverage by 0.30%. The diff coverage is 53.48%.

@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
- Coverage   69.63%   69.34%   -0.30%     
==========================================
  Files          23       23              
  Lines        2279     2306      +27     
  Branches      568      575       +7     
==========================================
+ Hits         1587     1599      +12     
- Misses        586      598      +12     
- Partials      106      109       +3     

Impacted Files	Coverage Δ
ord_schema/orm/scripts/add_datasets.py	54.71% <21.42%> (ø)
ord_schema/validations.py	70.28% <28.57%> (-0.35%)	:arrow_down:
ord_schema/message_helpers.py	86.25% <50.00%> (-0.78%)	:arrow_down:
ord_schema/orm/conftest.py	95.83% <100.00%> (ø)
ord_schema/orm/database.py	92.64% <100.00%> (+0.45%)	:arrow_up:
ord_schema/orm/mappers.py	95.73% <100.00%> (+0.07%)	:arrow_up:

[skearnes]

Please run the compile_proto_wrappers.sh and format.sh scripts so the tests pass.

[qai222]

Please run the compile_proto_wrappers.sh and format.sh scripts so the tests pass.

compile_proto_wrappers.sh made some changes (deletions) that I don't quite understand, still, two tests failed. Using libprotoc 3.15.8.

[skearnes]

Please run the compile_proto_wrappers.sh and format.sh scripts so the tests pass.

compile_proto_wrappers.sh made some changes (deletions) that I don't quite understand, still, two tests failed. Using libprotoc 3.15.8.

Make sure you're using the same versions as in this test: https://github.com/open-reaction-database/ord-schema/blob/main/.github/workflows/run_tests.yml#L78