open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
92 stars 26 forks source link

put rdkit functions in the public schema #689

Closed skearnes closed 1 year ago

skearnes commented 1 year ago

The latest version of the rdkit extension includes some implicit casts that fail unless the extension is loaded in the public schema (see https://github.com/rdkit/rdkit/pull/5875/files#r1257400659).

codecov[bot] commented 1 year ago

Codecov Report

Merging #689 (c8b3afd) into main (758940c) will decrease coverage by 0.03%. The diff coverage is 60.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   69.41%   69.39%   -0.03%     
==========================================
  Files          23       23              
  Lines        2302     2297       -5     
  Branches      572      572              
==========================================
- Hits         1598     1594       -4     
+ Misses        596      595       -1     
  Partials      108      108              
Impacted Files Coverage Δ
ord_schema/orm/scripts/add_datasets.py 54.71% <0.00%> (ø)
ord_schema/orm/database.py 92.75% <66.66%> (+0.10%) :arrow_up:
ord_schema/orm/mappers.py 95.73% <100.00%> (ø)
ord_schema/orm/rdkit_mappers.py 92.63% <100.00%> (+0.55%) :arrow_up: