search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
92 stars 26 forks source link

Validation patch to change Compound Identifier strictness #692

Closed connorcoley closed 11 months ago

connorcoley commented 1 year ago

Addresses #691

codecov[bot] commented 1 year ago

Codecov Report

Merging #692 (7d13ff3) into main (aaaed3f) will decrease coverage by 0.14%. The diff coverage is 67.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   69.63%   69.49%   -0.14%     
==========================================
  Files          23       23              
  Lines        2279     2295      +16     
  Branches      568      572       +4     
==========================================
+ Hits         1587     1595       +8     
- Misses        586      593       +7     
- Partials      106      107       +1
Impacted Files Coverage Δ
ord_schema/orm/scripts/add_datasets.py 54.71% <21.42%> (ø)
ord_schema/message_helpers.py 86.25% <50.00%> (-0.78%) :arrow_down:
ord_schema/validations.py 71.07% <61.53%> (+0.45%) :arrow_up:
ord_schema/orm/database.py 92.75% <87.50%> (+0.56%) :arrow_up:
ord_schema/orm/conftest.py 95.83% <100.00%> (ø)
ord_schema/orm/mappers.py 95.73% <100.00%> (+0.07%) :arrow_up:
ord_schema/orm/rdkit_mappers.py 92.63% <100.00%> (+0.55%) :arrow_up: