Closed FanwangM closed 10 months ago
Merging #699 (17effeb) into main (4961279) will increase coverage by
0.02%
. Report is 1 commits behind head on main. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #699 +/- ##
==========================================
+ Coverage 69.33% 69.36% +0.02%
==========================================
Files 23 23
Lines 2322 2324 +2
Branches 589 590 +1
==========================================
+ Hits 1610 1612 +2
Misses 598 598
Partials 114 114
Files Changed | Coverage Δ | |
---|---|---|
ord_schema/templating.py | 95.31% <100.00%> (+0.15%) |
:arrow_up: |
Instead of doing string operations on the template pbtxt, it would be cleaner to remove the field from the
dataset
after it is generated by the enumeration, I think. WDYT?
This can be a cleaner solution. New changes are committed here.
One question, do we need to assign a reaction_id for each reaction in the database after the reaction list is constructed?
One question, do we need to assign a reaction_id for each reaction in the database after the reaction list is constructed?
No, the submission workflows will automatically assign a reaction_id
to each
The PR is an attempt to fix #697 by filtering out the line with reaction_id.