search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 26 forks source link

Update protocol complier usage because of protobuf updates #700

Closed FanwangM closed 1 year ago

FanwangM commented 1 year ago

Optional fields for proto3 are enabled by default, and no longer require the --experimental_allow_proto3_optional flag, https://github.com/protocolbuffers/protobuf/releases/tag/v3.15.0. We are using 22.3 and it should be safe to remove this option.

codecov[bot] commented 1 year ago

Codecov Report

Merging #700 (1d79626) into main (4961279) will increase coverage by 0.02%. Report is 3 commits behind head on main. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #700      +/-   ##
==========================================
+ Coverage   69.33%   69.36%   +0.02%     
==========================================
  Files          23       23              
  Lines        2322     2324       +2     
  Branches      589      590       +1     
==========================================
+ Hits         1610     1612       +2     
  Misses        598      598              
  Partials      114      114
Files Changed Coverage Δ
ord_schema/templating.py 95.31% <100.00%> (+0.15%) :arrow_up:
FanwangM commented 1 year ago

Given that this option does not break anything, I am going to merge it.