search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 26 forks source link

Add Pipette as AdditionDevice option #708

Closed connorcoley closed 3 months ago

bdeadman commented 8 months ago

Agree that Pipette will be a good AdditionDeviceType option to have.

Enum option has been added into bdeadman/ord-schema:schema_added_enums but I will have a think about other addition device options that synthesis chemists may need before making the pull request. The immediate gap that comes to mind is pump(s) but I know these are also defined under FlowConditions so there may be good reasons not to allow a pump enum under input AdditionDeviceType.

bdeadman commented 5 months ago

Issue #607 can also be addressed at the same time.

bdeadman commented 5 months ago

Pull request #718 will add pipette, and positive displacement pipette as options.

skearnes commented 3 months ago

@bdeadman is this issue done? Now it's just interface-side updates that remain?

bdeadman commented 3 months ago

@skearnes yes the schema side is done. Just waiting for the interface which has its own issue, so we can close this one.