Add addition device types, and analysis types - Githubissues

open-reaction-database / ord-schema

Schema for the Open Reaction Database

https://open-reaction-database.org

Apache License 2.0

92 stars 26 forks source link

Add addition device types, and analysis types #719

Closed FanwangM closed 2 months ago

FanwangM commented 2 months ago

This PR suppresses https://github.com/open-reaction-database/ord-schema/pull/718. The git history is retained to reflect the contributions of @bdeadman. There are two issues with the original PR:

[x] linting errors because of missing white space, differences between 2 white spaces and 4 spaces, and lines getting too long (fixed);
[x] all the protobuf py and js files need to be updated once the schema gets changed

Other changes:

The actions/checkout is also updated to v4;
The license header is updated to 2024.

This PR addresses https://github.com/open-reaction-database/ord-schema/issues/607 and https://github.com/open-reaction-database/ord-schema/issues/708.

bdeadman commented 2 months ago

Thanks @FanwangM. I'll have a proper look and review it tomorrow night when I'm back at a computer.