DOI parser false alarm - Githubissues

open-reaction-database / ord-schema

Schema for the Open Reaction Database

https://open-reaction-database.org

Apache License 2.0

95 stars 26 forks source link

DOI parser false alarm #728

Closed qai222 closed 3 months ago

qai222 commented 3 months ago

Describe the bug When running dataset validation with

python validate_dataset.py --input="dataset.pbtxt"

I got validation errors like

 validations.py:120: Validation error for dataset.pbtxt[319]:
    Reaction.provenance: DOI should be trimmed (10.1038/s41467-023-42446-5 -> 10.1038/s41467)

But 10.1038/s41467-023-42446-5 is a valid DOI.

Additional context Likely something wrong with this function

qai222 commented 3 months ago

addressed in #729