search

open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
93 stars 26 forks source link

Broken link in documentation #740

Closed bdeadman closed 3 weeks ago

bdeadman commented 1 month ago

Describe the bug The front page of ORD docs has a broken YouTube video at the bottom.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots image

Desktop (please complete the following information):

Additional context I expected to find the code for this page in https://github.com/open-reaction-database/ord-schema/blob/52b7da36b22faaa6e15f20173962e127a62e21b9/docs/index.rst but the YouTube link does not appear to be there.

bdeadman commented 1 month ago

The video is at https://youtu.be/UyHVwJUBDIk but set to private. Could this be in your YouTube account @skearnes @connorcoley?

skearnes commented 1 month ago

I think this was the RDKit UGM video; maybe @greglandrum made it private recently?

bdeadman commented 1 month ago

I thought it may have been one of these videos https://www.youtube.com/@openreactiondatabase9685 which are publicly available, but the settings may have changed to prevent embedding.

Do you know where the link is contained in the docs code? I was expecting to see it in index.rst but this looks like it has everything but the embedded video. If I can find it I will make a temporary fix by removing the video or redirecting it.

greglandrum commented 1 month ago

I think this was the RDKit UGM video; maybe @greglandrum made it private recently

To make presenters more comfortable and since the UGM videos generally don't age well, we "take them down" (i.e. make them private) after a couple of years. FWIW: it's been quite a while since I changed the visibility on the videos from the 2020 UGM.

@skearnes if you and @connorcoley want this one public again, I'm happy to change its visibility

skearnes commented 1 month ago

@greglandrum I think making that public again would be great; the concept overview is still very useful. Thanks!

greglandrum commented 1 month ago

@greglandrum I think making that public again would be great; the concept overview is still very useful. Thanks!

Done.

bdeadman commented 1 month ago

Note to self: The link to the video is contained here link, but it is only visible in the code.

bdeadman commented 1 month ago

The video is still showing as private. #745 removes this YouTube link and adds a link to the ORD YouTube channel instead.

skearnes commented 3 weeks ago

@greglandrum I think making that public again would be great; the concept overview is still very useful. Thanks!

Done.

@greglandrum the video is still showing as private? https://www.youtube-nocookie.com/embed/UyHVwJUBDIk?start=3

greglandrum commented 3 weeks ago

@greglandrum I think making that public again would be great; the concept overview is still very useful. Thanks!

Done.

@greglandrum the video is still showing as private? https://www.youtube-nocookie.com/embed/UyHVwJUBDIk?start=3

Weird. I'm not sure whaI did wrong. It's actually public now and your link above works.

skearnes commented 3 weeks ago

@greglandrum thanks!

bdeadman commented 3 weeks ago

Thanks @greglandrum. I have now created PR #749 to re-embed the video link in the docs front page. This PR also updates your affiliation in the advisory board list.

Closing issue as resolved.

greglandrum commented 3 weeks ago

Thanks for updating my affiliation @bdeadman