open-reaction-database / ord-schema

Schema for the Open Reaction Database
https://open-reaction-database.org
Apache License 2.0
95 stars 27 forks source link

Schema ENUMS that would be helpful #754

Open bdeadman opened 1 month ago

bdeadman commented 1 month ago

Addition Devices:

Analysis Data Types:

connorcoley commented 1 month ago

Addition Devices

I think an addition device of a scoop makes a ton of sense. I'm not sure about how to denote the stock solution with evaporation (i.e., the most concise description) but I get the sentiment and need to capture that. It's more like it's a solution-phase addition to the vessel followed by a preparation step to evaporate. I would probably record it as a solution-phase addition where the device is whatever was used for the solution, then put the evaporation step in details for now. Would be good to discuss!

Area Percent

For this, I would use type AREA, use the percentage value, and indicate is_normalized = True